Skip to content

Fix: update per user self-build feedback #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 18, 2025
Merged

Fix: update per user self-build feedback #261

merged 4 commits into from
Mar 18, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Mar 6, 2025

Proposed changes

Problem: Problems when running commands to "build" our docs locally. Affected file: CONTRIBUTING_DOCS.md

Checklist

Before merging a pull request, run through this checklist and mark each as complete.

  • I have read the contributing guidelines
  • I have signed the F5 Contributor License Agreement (CLA)
  • I have rebased my branch onto main
  • I have ensured my PR is targeting the main branch and pulling from my branch from my own fork
  • I have ensured that the commit messages adhere to Conventional Commits
  • I have ensured that documentation content adheres to the style guide
  • If the change involves potentially sensitive changes1, I have assessed the possible impact
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • I have ensured that existing tests pass after adding my changes
  • If applicable, I have updated README.md and CHANGELOG.md

Footnotes

  1. Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation. Please refer to our style guide for guidance about placeholder content. ↩

@mjang mjang self-assigned this Mar 6, 2025
@mjang mjang marked this pull request as ready for review March 6, 2025 14:41
@mjang mjang requested a review from a team as a code owner March 6, 2025 14:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

✅ Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/261/

@JTorreG JTorreG added the process documentation Documentation related to how the repository or documention itself is managed. label Mar 11, 2025
@ADubhlaoich ADubhlaoich merged commit e9b849a into main Mar 18, 2025
8 checks passed
@ADubhlaoich ADubhlaoich deleted the update-contributing-docs branch March 18, 2025 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@y82 y82 y82 approved these changes

Assignees

@mjang mjang

Labels
process documentation Documentation related to how the repository or documention itself is managed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mjang @ADubhlaoich @y82 @JTorreG